add unit test for GlobalRequestLimiter #1525
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1525 +/- ##
============================================
+ Coverage 43.99% 44.44% +0.44%
- Complexity 1727 1757 +30
============================================
Files 376 376
Lines 10682 10696 +14
Branches 1425 1427 +2
============================================
+ Hits 4700 4754 +54
+ Misses 5412 5364 -48
- Partials 570 578 +8 Continue to review full report at Codecov.
|
Signed-off-by: yunfeiyanggzq <yunfeiyang@buaa.edu.cn>
sczyh30
reviewed
Jun 11, 2020
| @Test | ||
| public void testChangeMaxAllowedQps(){ | ||
| ClusterServerConfigManager.setMaxAllowedQps(4000); | ||
| GlobalRequestLimiter.initIfAbsent("foo"); |
There was a problem hiding this comment.
You may need to reset the global config or storage in @Before/@After stage.
There was a problem hiding this comment.
done,In order to simplify the work, I have add these change to #1529, this pr will be closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yunfeiyanggzq yunfeiyang@buaa.edu.cn
Special notes for reviews
I am an asoc participant. I will be mainly responsible for the cluster flow control. I will supplement the missing unit tests while reading the relative code.Thanks for your help and review